[Spice-devel] [PATCH v2 3/4] use QXLState instead of RedDispatcher

[Frediano Ziglio]

> 
> On Thu, 3 Mar 2016, Frediano Ziglio wrote:
> [...]
> >  void red_qxl_init(QXLInstance *qxl)
> >  {
> > -    RedDispatcher *red_dispatcher;
> > +    QXLState *qxl_state;
> >      RedChannel *channel;
> >      ClientCbs client_cbs = { NULL, };
> >  
> >      spice_return_if_fail(qxl != NULL);
> > -    spice_return_if_fail(qxl->st->dispatcher == NULL);
> > +    spice_return_if_fail(qxl->st == NULL);
> 
> This change causes Xspice to crash on startup:
> 
> reds.c:3206:spice_server_add_interface: SPICE_INTERFACE_QXL
> (process:3165): Spice-CRITICAL **: red-qxl.c:944:red_qxl_init: condition
> `qxl->st == NULL' failed
> 
> Removing the offending assert gets Xspice to start again but that's
> probably not be the right fix...
> 

It is. Old code does not test state is NULL and just set.
I'll add the fix tomorrow.

Frediano