[Spice-devel] [PATCH] Fix regression initialising QXL interface

[Christophe Fergeau]

On Wed, Mar 09, 2016 at 10:25:59AM +0000, Frediano Ziglio wrote:
> st field in QXLInstance was not checked for NULL before
> initialisation.
> The additional check make Xspice crash during startup.
> 
> Reported-by: Francois Gouget <fgouget at codeweavers.com>
> ---
>  server/red-qxl.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/server/red-qxl.c b/server/red-qxl.c
> index 1d29496..491046f 100644
> --- a/server/red-qxl.c
> +++ b/server/red-qxl.c
> @@ -941,7 +941,6 @@ void red_qxl_init(RedsState *reds, QXLInstance *qxl)
>      ClientCbs client_cbs = { NULL, };
>  
>      spice_return_if_fail(qxl != NULL);
> -    spice_return_if_fail(qxl->st == NULL);
>  
>      static gsize initialized = FALSE;
>      if (g_once_init_enter(&initialized)) {

ACK. Is this only causing issues with Xspice? If qxl->st is not NULL
when we get into red_qxl_init(), it seems we are going to leak memory
(or that it was working by chance because we did not memset
QXLInstance to 0).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160309/0f502bd8/attachment.sig>