[Spice-devel] [PATCH spice-common] RFC: add back codegen

[Christophe Fergeau]

On Wed, Mar 09, 2016 at 03:02:53PM +0100, Marc-André Lureau wrote:
> > Longer term, I think it should be possible to autogenerate common/messages.h
> > and common/client_marshallers.h as well, which hopefully would avoid
> > the issue we currently have. I have some hackish code which generates a
> > correct common/client_marshallers.h file already, I haven't looked at
> > common/messages.h yet.
> 
> That wouldn't solve it all, you would still need spice-common for the
> rest of the code to link.

spice-protocol does not ship any generated file( apart from enums.h),
nor try to use this generated code. It ships the .proto file and the .py
files, and then spice-common calls spice-codegen.py in order to generate
the file it needs to parse spice-protocol.

> Imho, if you go that road, we better merge spice-proto & common.

Having a small 'spice-protocol parsing' library is probably better than
spice-common calling code generation scripts shipped by spice-protocol
indeed. I don't think the canvas/ssl/... code currently in spice-common
would make sense in spice-protocol though.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160309/f862a42e/attachment.sig>