[Spice-devel] [PATCH 09/15] char-device: Refactor spice_char_device_client_add a bit

Christophe Fergeau cfergeau at redhat.com
Thu Mar 10 09:56:59 UTC 2016


On Wed, Mar 09, 2016 at 12:05:56PM -0500, Frediano Ziglio wrote:
> > 
> > From: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > Factor out CharDeviceClientState creation out of
> > spice_char_device_client_add.
> > ---
> >  server/char-device.c | 54
> >  ++++++++++++++++++++++++++++++++++------------------
> >  1 file changed, 35 insertions(+), 19 deletions(-)
> > 
> > diff --git a/server/char-device.c b/server/char-device.c
> > index cda2d60..1d22a30 100644
> > --- a/server/char-device.c
> > +++ b/server/char-device.c
> > @@ -767,6 +767,37 @@ void
> > spice_char_device_state_destroy(SpiceCharDeviceState *char_dev)
> >      spice_char_device_state_unref(char_dev);
> >  }
> >  
> > +SpiceCharDeviceClientState *red_char_device_client_new(RedClient *client,
> > +                                                       int do_flow_control,
> > +                                                       uint32_t max_send_queue_size,
> > +                                                       uint32_t num_client_tokens,
> > +                                                       uint32_t num_send_tokens)
> > +{
> 
> Why not static?

Probably just forgot, it's indeed not used out of char-device.c

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160310/34e47a89/attachment.sig>


More information about the Spice-devel mailing list