[Spice-devel] [PATCH 14/15] smartcard: Move private constant to C file

[Pavel Grunt]

On Thu, 2016-03-10 at 05:40 -0500, Frediano Ziglio wrote:
> > 
> > 
> > On Wed, 2016-03-09 at 16:28 +0000, Frediano Ziglio wrote:
> > > 
> > > From: Christophe Fergeau <cfergeau at redhat.com>
> > > 
> > > APDUBufSize is only used within smartcard.c, no need to expose it
> > > in
> > > smartcard.h
> > Acked-by: Pavel Grunt <pgrunt at redhat.com>
> > > 
> > > ---
> > >  server/smartcard.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/server/smartcard.c b/server/smartcard.c
> > > index 73c11e9..d417a23 100644
> > > --- a/server/smartcard.c
> > > +++ b/server/smartcard.c
> > > @@ -46,6 +46,9 @@
> > >   */
> > >  #define SMARTCARD_MAX_READERS 10
> > >  
> > > +// Maximal length of APDU
> > > +#define APDUBufSize 270
> > > +
> > >  typedef struct SmartCardDeviceState SmartCardDeviceState;
> > >  
> > >  typedef struct SmartCardChannelClient {
> No nacking but I would also remove the constant from the header file.
> With this change I would ack.
> 
> Frediano

Right, no reason to duplicate it

Pavel