[Spice-devel] [PATCH] Cap logging level to the valid bounds

Frediano Ziglio fziglio at redhat.com
Thu Mar 10 16:29:39 UTC 2016


Avoid overflows using its values.
The patch was originally written by Christophe Fergeau
---
 common/log.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/common/log.c b/common/log.c
index a9bbebc..8d47cb6 100644
--- a/common/log.c
+++ b/common/log.c
@@ -50,7 +50,8 @@ static GLogLevelFlags spice_log_level_to_glib(SpiceLogLevel level)
         [ SPICE_LOG_LEVEL_INFO ] = G_LOG_LEVEL_INFO,
         [ SPICE_LOG_LEVEL_DEBUG ] = G_LOG_LEVEL_DEBUG,
     };
-    g_return_val_if_fail ((level >= 0) || (level < G_N_ELEMENTS(glib_levels)), 0);
+    g_return_val_if_fail (level >= 0, G_LOG_LEVEL_ERROR);
+    g_return_val_if_fail (level < G_N_ELEMENTS(glib_levels), G_LOG_LEVEL_DEBUG);
 
     return glib_levels[level];
 }
-- 
2.5.0



More information about the Spice-devel mailing list