[Spice-devel] [PATCH spice-gtk] display: Lower level of warning for empty monitor config

[Frediano Ziglio]

> 
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1061942

Not so important but I'll put some more information on the
message. Would make easier to understand if somebody looks
at the change without opening an external website.

I think you can close the bug once this get into master.

Thinking that this is a not common situation but possible
(like turning off all monitors) would not be good to avoid
the return and set all monitors to not available?
However this is a different improvement that has nothing
to do with this commit. Also you would have to take into
consideration how a remote machine with all switched off
monitor should be displayed on the client.

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano


> ---
>  src/channel-display.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 5111d3d..dc00c31 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -1844,7 +1844,11 @@ static void
> display_handle_monitors_config(SpiceChannel *channel, SpiceMsgIn *in
>      guint i;
>  
>      g_return_if_fail(config != NULL);
> -    g_return_if_fail(config->count > 0);
> +
> +    if (config->count == 0) {
> +        CHANNEL_DEBUG(channel, "received empty monitor config");
> +        return;
> +    }
>  
>      CHANNEL_DEBUG(channel, "received new monitors config from guest: n:
>      %d/%d", config->count, config->max_allowed);
>