[Spice-devel] [PATCH spice-gtk] display: Lower level of warning for empty monitor config

[Victor Toso]

Hi,

On Fri, Mar 11, 2016 at 09:08:07AM +0100, Pavel Grunt wrote:
> Related:
> https://bugzilla.redhat.com/show_bug.cgi?id=1061942
> ---
>  src/channel-display.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 5111d3d..dc00c31 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -1844,7 +1844,11 @@ static void display_handle_monitors_config(SpiceChannel *channel, SpiceMsgIn *in
>      guint i;
>
>      g_return_if_fail(config != NULL);
> -    g_return_if_fail(config->count > 0);
> +
> +    if (config->count == 0) {
> +        CHANNEL_DEBUG(channel, "received empty monitor config");
> +        return;
> +    }

Is it common (and expected) now? Otherwise warning might be better?

>
>      CHANNEL_DEBUG(channel, "received new monitors config from guest: n: %d/%d", config->count, config->max_allowed);
>  
> -- 
> 2.7.2
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel