[Spice-devel] [PATCHv3 spice-gtk] build-sys: fix make check when polkit not available

[Jonathon Jongsma]

Hmm, that initial empty noinst_PROGRAMS looks a bit like a mistake. Perhaps add
a $(NULL) to that to make it explicit?

ACK either way

Acked-by: Jonathon Jongsma <jjongsma at redhat.com>



On Fri, 2016-03-11 at 20:04 +0100, Marc-André Lureau wrote:
> acl-helper needs polkit (and unix atm) to build.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> ---
>  tests/Makefile.am | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 24d45c9..c1d95c1 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1,18 +1,21 @@
>  NULL =
>  
> +noinst_PROGRAMS =
>  TESTS = coroutine				\
>  	util					\
>  	session					\
> -	usb-acl-helper				\
>  	$(NULL)
>  
>  if WITH_PHODAV
>  TESTS += pipe
>  endif
>  
> -noinst_PROGRAMS = $(TESTS) \
> -		  mock-acl-helper \
> -		  $(NULL)
> +if WITH_POLKIT
> +TESTS += usb-acl-helper
> +noinst_PROGRAMS += mock-acl-helper
> +endif
> +
> +noinst_PROGRAMS += $(TESTS)
>  
>  AM_CPPFLAGS =					\
>  	$(COMMON_CFLAGS)			\