[Spice-devel] [PATCH spice-gtk 2/3] spice-display: Remove auto-clipboard notify

[Eduardo Lima (Etrunko)]

On 03/16/2016 10:46 AM, Pavel Grunt wrote:
> It was used to notify the (deprecated) auto-clipboard property of
> the SpiceDisplay everytime the SpiceGtkSession emits its auto-clipboard
> notify.
> 
> The commit 70a00b8fcc2ca85d3601f6ac4895f906f9032e77 removed the property
> from SpiceDisplay causing a runtime warning:
> 
> GLib-GObject-WARNING **: g_object_notify: object class 'SpiceDisplay' has no property named 'auto-clipboard'
> ---
>  src/spice-widget.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index f86054f..30426be 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -390,15 +390,6 @@ static void spice_display_set_property(GObject      *object,
>      }
>  }
>  
> -static void gtk_session_property_changed(GObject    *gobject,
> -                                         GParamSpec *pspec,
> -                                         gpointer    user_data)
> -{
> -    SpiceDisplay *display = user_data;
> -
> -    g_object_notify(G_OBJECT(display), g_param_spec_get_name(pspec));
> -}
> -
>  static void session_inhibit_keyboard_grab_changed(GObject    *gobject,
>                                                    GParamSpec *pspec,
>                                                    gpointer    user_data)
> @@ -689,9 +680,6 @@ spice_display_constructor(GType                  gtype,
>      }
>      g_list_free(list);
>  
> -    spice_g_signal_connect_object(d->gtk_session, "notify::auto-clipboard",
> -                                  G_CALLBACK(gtk_session_property_changed), display, 0);
> -
>      spice_g_signal_connect_object(d->session, "notify::inhibit-keyboard-grab",
>                                    G_CALLBACK(session_inhibit_keyboard_grab_changed),
>                                    display, 0);
> 
Acked-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com