[Spice-devel] [phodav PATCH 3/7 v3] spice-webdavd-windows: Alert when CreateFile fails

Lukas Venhoda lvenhoda at redhat.com
Thu Mar 17 13:47:47 UTC 2016


Shows alert on windows when CreateFile fails.
This can happen, when webdavd is run without administrator privileges.

Acked-by: Marc-André Lureau <mlureau at redhat.com>
---
Changes since v2:
 - None
Changes since v1:
 - Split patch into 2
---
 spice/spice-webdavd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index c8fb795..b3fd1ea 100644
--- a/spice/spice-webdavd.c
+++ b/spice/spice-webdavd.c
@@ -722,7 +722,9 @@ open_mux_path (const char *path)
                          OPEN_EXISTING,
                          FILE_FLAG_OVERLAPPED,
                          NULL);
-  g_assert (port_handle != INVALID_HANDLE_VALUE);
+
+  if (port_handle == INVALID_HANDLE_VALUE)
+      g_error ("%s", g_win32_error_message (GetLastError ()));

   mux_ostream = G_OUTPUT_STREAM (g_win32_output_stream_new (port_handle, TRUE));
   mux_istream = G_INPUT_STREAM (g_win32_input_stream_new (port_handle, TRUE));
--
2.5.0



More information about the Spice-devel mailing list