[Spice-devel] spice-html5 keyboard layout fix proposal

[Jeremy White]

Hi Eric,

This is great; thanks for taking the time to put this together.

Could I ask a few favors, though?  This version did not apply to the git
tip for me.  I think a few corrections Christophe made recently keep
your utils.js change from applying.

Additionally, if you could keep the spice.html change out of this patch,
that would help in reviewing.

A brief overview suggests your changes are promising.  However, I did
find a fair number of keys that no longer work (.=; q and a are
reversed, there are others).  I'm also troubled that you've taken out
some of the Firefox specific scan codes - did yuo try multiple browsers
as you worked on this?

And can I presume that this code as written works reasonably well for you?

Cheers,

Jeremy

On 03/17/2016 11:50 AM, Eric Grammatico wrote:
> Gentle(wo)men,
> 
> I have spent time to fix the keyboard layout in spice-html5. I went to
> the conclusion the keyboard layout cannot be configured on client
> (html5) side as Xorg receives key code it interpretes. What ever the key
> face the user has typed (A or Q) Xorg will map to the character
> depending of its configuration.
> 
> The drawback was on my setup Xspice ignores my keyboard config and the
> only way I found to force my keyboard layout was to launch setxkbmap
> from .xinitrc.
> 
> I kept the same structure around utils.js, atKeynames.js and inputs.js.
> In atKeynames I mapped the Xorg symbols defined in
> /usr/share/X11/xkb/symbols. This way, all the non changing keys (like
> ESCAPE) through the different layouts are well defined and the others
> are map to symbols like AD01. In some how it's kept readable...
> 
> Then I have updated utils.js and inputs.js in consequence.
> 
> Please find attached my diff file as a proposal. Tests and comments are
> very wellcome.
> 
> Thanks and regards,
> 
> -
> _/) Eric Grammatico.
> 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>