[Spice-devel] [qxl 5/5] spiceqxl_audio: Stop the playback channel if there is nothing to play

[Jeremy White]

Hey Francois,

> @@ -361,14 +366,23 @@ static void start_watching(qxl_screen_t *qxl)
>      }
>  }
>  
> +/* a helper for read_from_fifos() */
>  static void wall_ticker(void *opaque)
>  {
>      qxl_screen_t *qxl = opaque;
>      struct audio_data *data = qxl->playback_opaque;
>  
> -    data->wall_timer_live = 0;
> -
> -    read_from_fifos(-1, 0, qxl);
> +    if (data->wall_timer_type == IDLE_MS) {
> +        /* There is no open fifo anymore */

I think this comment is not necessarily correct.  The fifos could still
be open, just not producing audio data, right?

Cheers,

Jeremy