[Spice-devel] [qxl 0/5] Xspice audio playback fixes

[Jeremy White]

Hey Francois,

On 03/18/2016 09:31 AM, Francois Gouget wrote:
> 
> While testing the video streaming I ran into a number of issues caused 
> by Xspice's audio playback. So I investigated those and found fixes 
> which gives this patch series.
> 
> This patch set is totally independent from the video streaming series. 
> That said it does help test video streaming special cases as described 
> below:

I had one comment on a comment in patch 5, but I've tested this; it all
works, and the patches all also look correct to me.  So modulo a comment
on patch 5, ACK series.

Cheers,

Jeremy
> 
> 
> Francois Gouget (5):
>   spiceqxl_audio: Let the audio play when no client is connected
>   - This allows testing what happens to video streaming when there is 
>     no client.
> 
>   spiceqxl_audio: Only condense the fifo list when one has been closed
> 
>   spiceqxl_audio: Fix a race condition in the audio playback
>   - By preventing the audio from getting stuck after a while this 
>     allows testing the video streaming for longer periods.
> 
>   spiceqxl_audio: Only start the playback channel when fifos are present
>   - This allows testing the video streaming independently from the 
>     audio, and thus to determine which side is causing trouble.
> 
>   spiceqxl_audio: Stop the playback channel if there is nothing to play
> 
>  src/spiceqxl_audio.c | 174 ++++++++++++++++++++++++++++++++-------------------
>  1 file changed, 109 insertions(+), 65 deletions(-)
>