[Spice-devel] [PATCH spice-gtk] spicy: Remove configure-event callback

Christophe Fergeau cfergeau at redhat.com
Wed Mar 23 16:10:41 UTC 2016


On Wed, Mar 23, 2016 at 05:06:21PM +0100, Pavel Grunt wrote:
> It is a leftover - see "Remove GnomeRR code"
> commit 30986505ba6041c293c38cb4b7f4b618a59f4716

Ah ok it's no longer doing anything useful after this commit.

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

> ---
>  src/spicy.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/src/spicy.c b/src/spicy.c
> index 6ca014b..ca9db84 100644
> --- a/src/spicy.c
> +++ b/src/spicy.c
> @@ -878,23 +878,6 @@ static void recent_item_activated_cb(GtkRecentChooser *chooser, gpointer data)
>      connection_connect(conn);
>  }
>  
> -static gboolean configure_event_cb(GtkWidget         *widget,
> -                                   GdkEventConfigure *event,
> -                                   gpointer           data)
> -{
> -    gboolean resize_guest;
> -    SpiceWindow *win = data;
> -
> -    g_return_val_if_fail(win != NULL, FALSE);
> -    g_return_val_if_fail(win->conn != NULL, FALSE);
> -
> -    g_object_get(win->spice, "resize-guest", &resize_guest, NULL);
> -    if (resize_guest && win->conn->agent_connected)
> -        return FALSE;
> -
> -    return FALSE;
> -}
> -
>  static void compression_cb(GtkRadioAction *action G_GNUC_UNUSED,
>                             GtkRadioAction *current,
>                             gpointer user_data)
> @@ -988,7 +971,6 @@ static SpiceWindow *create_spice_window(spice_connection *conn, SpiceChannel *ch
>  
>      /* spice display */
>      win->spice = GTK_WIDGET(spice_display_new_with_monitor(conn->session, id, monitor_id));
> -    g_signal_connect(win->spice, "configure-event", G_CALLBACK(configure_event_cb), win);
>      seq = spice_grab_sequence_new_from_string("Shift_L+F12");
>      spice_display_set_grab_keys(SPICE_DISPLAY(win->spice), seq);
>      spice_grab_sequence_free(seq);
> -- 
> 2.7.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160323/fc4ee41b/attachment.sig>


More information about the Spice-devel mailing list