[Spice-devel] [PATCH spice-gtk v2 9/8] main: don't update display timer for unchanged config

[Marc-André Lureau]

Hi Jonathon

On Wed, Mar 23, 2016 at 8:58 PM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
>> It also solves/avoids problems with a guest running on wayland when the
>> "resize-guest" property is TRUE.
>> See bug https://bugzilla.redhat.com/show_bug.cgi?id=1266484 ;
>> It avoids destroying the primary surface when the display configuration
>> has not changed
>
> hmm.  so, the suggestion from my previous email (only compare with previous
> config and return early from update_display() if there's currently a pending
> config message scheduled) would probably break this case again (if I understand
> the situation correctly). Do you know *why* we're repeatedly updating to the
> same monitor config under wayland?

I don't fully understand your hypotetical issue. You said in practice
it cannot happen. Do you want to investigate it further before we
apply this fix? I'd apply now, as it fixes 2 existing problems ;)

thanks


-- 
Marc-André Lureau