[Spice-devel] [PATCH 2/2] dispatcher: move channel final initialization to red-worker

[Christophe Fergeau]

On Thu, Mar 24, 2016 at 02:19:22PM +0000, Frediano Ziglio wrote:
> CursorChannel and DisplayChannel was initialized half in red_worker_new
> and half in red_dispatcher_init using some accessor for RedWorker
> (red_worker_get_cursor_channel and red_worker_get_display_channel).
> Moving directly into red_worker_new make easier to follow code path.

To me, the generation of 'payload' data and the call to
dispatcher_send_message() belongs in dispatcher implementations, ie
red-qxl.c. Before this commit:
$ git grep -l dispatcher_send_message
server/dispatcher.c
server/dispatcher.h
server/main-dispatcher.c
server/red-qxl.c

so this commit would move some of these to red-worker.c. Imo this is a
move in the wrong direction.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160324/78d5d3f9/attachment.sig>