[Spice-devel] [[PATCH] [spice-common] 1/2] Update glib requirements to 2.38

Christophe Fergeau cfergeau at redhat.com
Tue Mar 29 08:18:35 UTC 2016


Hey,

On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote:
> From: "Eduardo Lima (Etrunko)" <etrunko at redhat.com>
> 
> Recent logging tests make use of g_test_subprocess() and
> g_test_trap_subprocess() functions, available only in glib newer than
> 2.38.

glib 2.38 is far too new to be used as the global required version for
spice and spice-gtk. We should disable these tests when a too old glib
is used.

Christophe

> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  configure.ac     | 2 +-
>  m4/spice-deps.m4 | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 2ff985d..bfdf869 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -35,7 +35,7 @@ SPICE_CHECK_PYTHON_MODULES()
>  SPICE_CHECK_PIXMAN
>  SPICE_CHECK_SMARTCARD
>  SPICE_CHECK_CELT051
> -SPICE_CHECK_GLIB2
> +SPICE_CHECK_GLIB2(2.38)
>  SPICE_CHECK_OPUS
>  SPICE_CHECK_OPENGL
>  
> diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4
> index 88edf7e..ecae80a 100644
> --- a/m4/spice-deps.m4
> +++ b/m4/spice-deps.m4
> @@ -173,7 +173,7 @@ AC_DEFUN([SPICE_CHECK_PIXMAN], [
>  # use in the GLIB2_CFLAGS and GLIB2_LIBS variables.
>  #------------------
>  AC_DEFUN([SPICE_CHECK_GLIB2], [
> -    PKG_CHECK_MODULES(GLIB2, glib-2.0 >= 2.22 gio-2.0 >= 2.22)
> +    PKG_CHECK_MODULES(GLIB2, glib-2.0 >= $1 gio-2.0 >= $1)
>  ])
>  
>  # SPICE_CHECK_PYTHON_MODULES()
> -- 
> 1.8.3.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160329/a3b07dcf/attachment.sig>


More information about the Spice-devel mailing list