[Spice-devel] [PATCH] memslot: do not crash if guest provide a wrong address

[Christophe Fergeau]

Hey,

I believe this could be pushed to the 0.12 branch as well?

Christophe

On Thu, Feb 18, 2016 at 09:49:45AM +0000, Frediano Ziglio wrote:
> This could happen with buggy driver.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/memslot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/memslot.c b/server/memslot.c
> index 768762b..99c63e4 100644
> --- a/server/memslot.c
> +++ b/server/memslot.c
> @@ -61,7 +61,7 @@ int memslot_validate_virt(RedMemSlotInfo *info, unsigned long virt, int slot_id,
>  
>      if (virt < slot->virt_start_addr || (virt + add_size) > slot->virt_end_addr) {
>          print_memslots(info);
> -        spice_critical("virtual address out of range\n"
> +        spice_warning("virtual address out of range\n"
>                "    virt=0x%lx+0x%x slot_id=%d group_id=%d\n"
>                "    slot=0x%lx-0x%lx delta=0x%lx",
>                virt, add_size, slot_id, group_id,
> -- 
> 2.5.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160329/51fafd07/attachment.sig>