[Spice-devel] [[PATCH] [spice-common] 1/2] Update glib requirements to 2.38

[Christophe Fergeau]

On Tue, Mar 29, 2016 at 09:26:49AM -0300, Eduardo Lima (Etrunko) wrote:
> On 03/29/2016 05:18 AM, Christophe Fergeau wrote:
> > Hey,
> > 
> > On Mon, Mar 28, 2016 at 06:00:27PM -0300, Eduardo Lima (Etrunko) wrote:
> >> From: "Eduardo Lima (Etrunko)" <etrunko at redhat.com>
> >>
> >> Recent logging tests make use of g_test_subprocess() and
> >> g_test_trap_subprocess() functions, available only in glib newer than
> >> 2.38.
> > 
> > glib 2.38 is far too new to be used as the global required version for
> > spice and spice-gtk. We should disable these tests when a too old glib
> > is used.
> 
> Well, at least for spice-gtk there is a requirement for recent Gtk+
> version, which I _think_ may force a newer glib version as well. Also,
> for virt-viewer we already require 2.38.

spice(-server) uses the spice-common submodule and only requires glib
2.22.

> 
> Anyway, I can add the --disable-tests flag if you think it is a better
> solution.

--disable-tests would work, but I had in mind something more automatic:
dnl <insert glib 2.38 detection here>
AM_CONDITIONAL(HAVE_GLIB_2_38, [test "x$have_glib_2_38" == "xyes"])

and then only build the tests needing a newer glib if this conditional
was set.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160329/a77fc411/attachment.sig>