[Spice-devel] [PATCH] Remove duplicate typedef from headers

[Christophe Fergeau]

On Wed, Mar 30, 2016 at 05:33:50PM +0100, Frediano Ziglio wrote:
> This is causing compile errors with older gcc versions.
> 
> reds.h includes reds-stream.h through red-channel.h so it will get the
> RedsState typedef this way.
> 
> red-qxl.h includes spice-qxl.h through red-channel.h and then spice.h,
> so it will get the QXLState typedef this way.
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/main-dispatcher.h | 2 +-
>  server/red-qxl.h         | 2 --
>  server/reds-stream.h     | 3 +--
>  3 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/server/main-dispatcher.h b/server/main-dispatcher.h
> index ffe82c8..35811d7 100644
> --- a/server/main-dispatcher.h
> +++ b/server/main-dispatcher.h
> @@ -58,6 +58,6 @@ void main_dispatcher_set_mm_time_latency(MainDispatcher *self, RedClient *client
>   */
>  void main_dispatcher_client_disconnect(MainDispatcher *self, RedClient *client);
>  
> -MainDispatcher* main_dispatcher_new(RedsState *reds, SpiceCoreInterfaceInternal *core);
> +MainDispatcher* main_dispatcher_new(SpiceServer *reds, SpiceCoreInterfaceInternal *core);

With the .c file still using RedsState * for main_dispatcher_new(), NACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160330/a23c7ddf/attachment.sig>