[Spice-devel] How to modify spice version?

[Eduardo Lima (Etrunko)]

On 05/02/2016 09:46 AM, Marc-André Lureau wrote:
> Hi
> 
> On Fri, Apr 29, 2016 at 9:10 PM, Eduardo Lima (Etrunko)
> <etrunko at redhat.com> wrote:
>> On 04/29/2016 12:29 PM, Eduardo Lima (Etrunko) wrote:
>>> On 04/28/2016 08:45 AM, Pavel Grunt wrote:
>>>> Hi,
>>>>
>>>> On Thu, 2016-04-28 at 14:09 +0800, Chen yu wrote:
>>>>> Thank you for taking time out of your busy schedule to see this letter.
>>>>> I am trying to compile spice downloaded from github, but the versions of these
>>>>> are 'UNKNOWN'. when I compiled QEMU with these spice, there have some errors
>>>>> in the process of 'make'.
>>>>> Could I modify the version of spice (spice-server and spice-gtk) temporarily
>>>>> for testing and how should I do?
>>>>
>>>>
>>>> Please, use repos from freedesktop https://cgit.freedesktop.org/spice/
>>>> The github repos are mirrored, but they don't have tags, so they cannot generate
>>>> version.
>>>>
>>>
>>> Hmm, this should be fixed anyway, by pushing the tags to the github
>>> repositories and also implement some fallback method in git-version-gen.
> 
> Yes, tags must be present.
> 
>>
>>
>> So, as far as I understand, there are two issues.
>>
>> 1) We should have specified --fallback in AC_INIT line
> 
> Why "should we"? even autoconf.git (the source of the script) isn't using it.
> 
> http://git.savannah.gnu.org/cgit/autoconf.git/tree/configure.ac
> 

Well, the fact that they are not using it does not removes the need for
a fallback. Especially when the script provides the fallback option and
it is buggy, as I already mentioned. What I did was simply fix that
option so we can use it.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com