[Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject
Frediano Ziglio
fziglio at redhat.com
Wed May 4 08:30:35 UTC 2016
A patch of this size cannot be accepted, no matter how good it is.
We need to find a way to split it.
Any proposal would be good.
Frediano
>
> When using private structs with GObject, there's a maximum size of (I
> think) 64k, which was exceeded by the DisplayChannel object. To make
> this work, I had to make several of the arrays here dynamically
> allocated rather than statically allocated.
> ---
> server/Makefile.am | 5 +
> server/common-graphics-channel-client.c | 3 +-
> server/common-graphics-channel-client.h | 3 +-
> server/common-graphics-channel.c | 181 ++++++++
> server/common-graphics-channel.h | 98 +++++
> server/cursor-channel.c | 126 +++---
> server/cursor-channel.h | 37 +-
> server/dcc-send.c | 44 +-
> server/dcc.c | 61 +--
> server/dcc.h | 4 +-
> server/display-channel-private.h | 81 ++++
> server/display-channel.c | 726
> ++++++++++++++++++++------------
> server/display-channel.h | 158 +++----
> server/dummy-channel-client.c | 17 +-
> server/dummy-channel.c | 58 +++
> server/dummy-channel.h | 61 +++
> server/inputs-channel.c | 262 +++++++-----
> server/inputs-channel.h | 30 ++
> server/main-channel-client.c | 47 +--
> server/main-channel-client.h | 4 +-
> server/main-channel.c | 241 ++++++-----
> server/main-channel.h | 44 +-
> server/red-channel-client-private.h | 19 +
> server/red-channel-client.c | 197 +++++----
> server/red-channel-client.h | 6 +-
> server/red-channel.c | 684 ++++++++++++++++++++----------
> server/red-channel.h | 190 ++++-----
> server/red-parse-qxl.h | 2 +
> server/red-qxl.c | 21 +-
> server/red-replay-qxl.c | 2 +-
> server/red-worker.c | 197 ++-------
> server/red-worker.h | 64 ---
> server/reds-private.h | 3 +-
> server/reds.c | 67 +--
> server/smartcard.c | 131 ++++--
> server/sound.c | 43 +-
> server/spicevmc.c | 339 ++++++++++-----
> server/stream.c | 67 +--
> server/stream.h | 3 -
> 39 files changed, 2753 insertions(+), 1573 deletions(-)
> create mode 100644 server/common-graphics-channel.c
> create mode 100644 server/common-graphics-channel.h
> create mode 100644 server/display-channel-private.h
> create mode 100644 server/dummy-channel.c
> create mode 100644 server/dummy-channel.h
>
....
More information about the Spice-devel
mailing list