[Spice-devel] [PATCH] Make asciidoc a hard requirement

[Christophe Fergeau]

On Wed, May 04, 2016 at 09:09:41AM -0300, Eduardo Lima (Etrunko) wrote:
> The thing to notice here is that we are talking about two different
> events, one is configure and the other one is make. Make depends on the
> results of configure, but there is no way to know, at configure time,
> which arguments the make will receive, so the right thing to do is to
> prepare for all of them.
> 
> Checking for a dependency that will be only used in make dist is wrong
> and adds unnecessary maintenance burden in autofoo files which are by
> themselves already too complex to mess with.
> 
> > I have no problem accepting patches that make "make dist" require
> > asciidoc, but I think we should not build the manual by default.
> > 
> 
> It is possible to have the manual built only for make dist, but I would
> still keep asciidoc as a mandatory dependency.

That would be a bit weird imo. Since 'make dist' is not something I
expect a lot of people to run, I think it's fine to not check for what
it requires in configure, we can nicely error out when someone tries to
run make dist without --enable-manual.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160504/7448eeb5/attachment.sig>