[Spice-devel] [PATCH] remove dandling pointer for RedCharDeviceVDIPort

[Eduardo Lima (Etrunko)]

On 05/04/2016 05:51 AM, Frediano Ziglio wrote:
>>
>>>
>>> Honestly more I look at the patch and this fix and more I think it's all
>>> a big bug...
>>> What I know for sure is that this patch fix a dandling pointer.
>>
>> That's true.
>> But I think we should have a better fix that does not ignore the value
>> of agent_attached, or at least we should verify that other uses of this
>> variable are correct and this is the only place needs fixing.
>>
> 
> Don't be confused by the check removal. Previously (before the offending
> commit) the check was checking the existence of RedCharDevice. Now
> RedCharDevice is always present so the check should be removed.
> 
> I don't see any reason why this patch should not be merged (beside the
> comment typo fix).


I was able to confirm that there is no more crash with our tests after
this patch is applied.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com