[Spice-devel] [PATCH 14/14] Convert RedChannel heirarchy to GObject

[Daniel P. Berrange]

On Wed, May 04, 2016 at 04:30:35AM -0400, Frediano Ziglio wrote:
> A patch of this size cannot be accepted, no matter how good it is.
> We need to find a way to split it.
> 
> Any proposal would be good.

There's some simple things which could be done ahead of the main conversion
to GObject.

 - API renames - eg get_stream_id -> display_channel_get_stream_id
 - Macro renames - you can introduce DISPLAY_CHANNEL before the
   conversion by defining it in terms of SPICE_CONTAINEROF

When converting to GObject you can also avoid adding the the XXXPrivate
structs - just put all the fields in the public object struct. Then
introcuce the XXXPrivate structs as a second step.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|