[Spice-devel] [PATCH v2 2/2] fix crash if agent interface is removed

Christophe Fergeau cfergeau at redhat.com
Mon May 9 12:20:55 UTC 2016


Hey,

On Mon, May 09, 2016 at 10:03:03AM +0100, Frediano Ziglio wrote:
> Removing an interface cause SpiceBaseInstance->st to be set to NULL.
> This pointer was then deferenced in agent code.
> As SpiceBaseInstance should not be used after this call make sure
> we don't keep pointers to it.

I guess it cannot hurt... However, it would be a good time to document
how we expect char_device_attach/remove to behave wrt to the lifetime of
the various instances we have (char device, sin, vdagent, ...).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160509/1e6e4d2f/attachment.sig>


More information about the Spice-devel mailing list