[Spice-devel] [spice-gtk v1] spicy: fix leak of transfer hash table

Victor Toso lists at victortoso.com
Tue May 10 11:01:44 UTC 2016


Hi,

On Tue, May 10, 2016 at 11:16:43AM +0200, Christophe Fergeau wrote:
> 
> Acked-by: Christophe Fergeau <cfergeau at redhat.com>

Thanks, pushed as
https://cgit.freedesktop.org/spice/spice-gtk/commit/?id=e6ca385208d68204c470b51e312582bba8076551

> 
> On Tue, May 10, 2016 at 10:28:28AM +0200, Victor Toso wrote:
> > 184 (88 direct, 96 indirect) bytes in 1 blocks are definitely lost in
> > loss record 10,025 of 11,515 at 0x4C28BF6: malloc
> > (vg_replace_malloc.c:299)
> >  by 0x9D33218: g_malloc (gmem.c:94)
> >  by 0x9D49D02: g_slice_alloc (gslice.c:1025)
> >  by 0x9D1CCBD: g_hash_table_new_full (ghash.c:711)
> >  by 0x406196: connection_new (spicy.c:1693)
> >  by 0x405BFE: main (spicy.c:1852)
> > ---
> >  src/spicy.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/spicy.c b/src/spicy.c
> > index 0475530..d19b95a 100644
> > --- a/src/spicy.c
> > +++ b/src/spicy.c
> > @@ -1715,6 +1715,7 @@ static void connection_disconnect(spice_connection *conn)
> >  static void connection_destroy(spice_connection *conn)
> >  {
> >      g_object_unref(conn->session);
> > +    g_hash_table_unref(conn->transfers);
> >      free(conn);
> >  
> >      connections--;
> > -- 
> > 2.5.5
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



More information about the Spice-devel mailing list