[Spice-devel] [spice-protocol PATCH v4] LZ4 compression is now available at the Spicevmc channel

[Snir Sheriber]

Hey,

On 05/10/2016 01:23 PM, Victor Toso wrote:
> Hi,
>
> On Thu, May 05, 2016 at 02:43:33PM +0300, Snir Sheriber wrote:
>> -New message type for compressed messages has been added to the protocol
>> -SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4 capability has been added
> Let's keep the commit messages under 72 char.
:)
>> ---
>>   spice/enums.h    | 10 ++++++++++
>>   spice/protocol.h |  4 ++++
>>   2 files changed, 14 insertions(+)
>>
>> diff --git a/spice/enums.h b/spice/enums.h
>> index c6e9840..cf49c3a 100644
>> --- a/spice/enums.h
>> +++ b/spice/enums.h
>> @@ -106,6 +106,14 @@ typedef enum SpiceMouseMode {
>>       SPICE_MOUSE_MODE_MASK = 0x3
>>   } SpiceMouseMode;
>>   
>> +typedef enum SpiceDataCompressionType {
>> +    SPICE_DATA_COMPRESSION_TYPE_NONE,
>> +    SPICE_DATA_COMPRESSION_TYPE_LZ4,
>> +    SPICE_DATA_COMPRESSION_TYPE_INVALID,
> SPICE_DATA_COMPRESSION_TYPE_INVALID is not used in your patches, maybe
> it could be removed then?
I thought it may be used later on if someone would use the 
SpiceMsgCompressedData
type to compress something else.. but it can be removed for now..
>
> Apart from this, looks good.
> Reviewed-by: Victor Toso <victortoso at redhat.com>
>
>> +
>> +    SPICE_DATA_COMPRESSION_TYPE_ENUM_END
>> +} SpiceDataCompressionType;
>> +
>>   typedef enum SpicePubkeyType {
>>       SPICE_PUBKEY_TYPE_INVALID,
>>       SPICE_PUBKEY_TYPE_RSA,
>> @@ -634,12 +642,14 @@ enum {
>>
>>   enum {
>>       SPICE_MSG_SPICEVMC_DATA = 101,
>> +    SPICE_MSG_SPICEVMC_COMPRESSED_DATA,
>>   
>>       SPICE_MSG_END_SPICEVMC
>>   };
>>   
>>   enum {
>>       SPICE_MSGC_SPICEVMC_DATA = 101,
>> +    SPICE_MSGC_SPICEVMC_COMPRESSED_DATA,
>>   
>>       SPICE_MSGC_END_SPICEVMC
>>   };
>> diff --git a/spice/protocol.h b/spice/protocol.h
>> index f4a2259..d742eda 100644
>> --- a/spice/protocol.h
>> +++ b/spice/protocol.h
>> @@ -148,6 +148,10 @@ enum {
>>   };
>>   
>>   enum {
>> +    SPICE_SPICEVMC_CAP_DATA_COMPRESS_LZ4,
>> +};
>> +
>> +enum {
>>       SPICE_PORT_EVENT_OPENED,
>>       SPICE_PORT_EVENT_CLOSED,
>>       SPICE_PORT_EVENT_BREAK,
>> -- 
>> 2.5.5
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/spice-devel