[Spice-devel] [PATCH] spice-html5: spice_auto.html - actually use ?path when given

Christophe Fergeau cfergeau at redhat.com
Thu May 12 15:17:15 UTC 2016


Hey,

Thanks for the patch, sorry for the very late answer :(

On Fri, May 06, 2016 at 08:25:13AM +0000, Martin Hradil wrote:
> Right now, `spice_auto.html` reads the path from query string .. and
> never actually does anything with it. This should make
> `spice_auth.html` respect a path parametr when given.
> 
> ---
>  spice_auto.html | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/spice_auto.html b/spice_auto.html
> index 5714804..9aae118 100644
> --- a/spice_auto.html
> +++ b/spice_auto.html
> @@ -128,6 +128,10 @@
> 
>                  uri = scheme + host + ":" + port;
> 
> +                if (path) {
> +                  uri += path[0] == '/' ? path : ('/' + path);
> +                }
> +

Yup, this matches what is done in spice.html, even though the code there
is less sophisticated:
uri = scheme + host + ":" + port + "/" + path;


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

I'll push this now.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160512/28ecb608/attachment.sig>


More information about the Spice-devel mailing list