[Spice-devel] [PATCH 04/11] let compiler manage the copy in a more typesafe way

Pavel Grunt pgrunt at redhat.com
Fri May 13 07:39:00 UTC 2016


On Thu, 2016-05-12 at 15:45 -0500, Jonathon Jongsma wrote:
> From: Frediano Ziglio <fziglio at redhat.com>
> 
> Do not use memcpy but just copy the data
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/red-channel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/red-channel.c b/server/red-channel.c
> index 66aed41..c88828c 100644
> --- a/server/red-channel.c
> +++ b/server/red-channel.c
> @@ -1049,7 +1049,7 @@ RedChannel *red_channel_create(int size,
>      channel->refs = 1;
>      channel->handle_acks = handle_acks;
>      channel->migration_flags = migration_flags;
> -    memcpy(&channel->channel_cbs, channel_cbs, sizeof(ChannelCbs));
> +    channel->channel_cbs = *channel_cbs;
>  
>      channel->reds = reds;
>      channel->core = core;


More information about the Spice-devel mailing list