[Spice-devel] [PATCH] fix wrong assert causing streaming to crash

Frediano Ziglio fziglio at redhat.com
Fri May 13 11:25:09 UTC 2016


This regression was introduced by commit
18d3876b78c7f19c577da000d322dbd44e63e456
("UpgradeItem: use base PipeItem for refcounting")

This fix https://bugs.freedesktop.org/show_bug.cgi?id=95365.

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/stream.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/stream.c b/server/stream.c
index 8884480..35eb7c2 100644
--- a/server/stream.c
+++ b/server/stream.c
@@ -761,7 +761,7 @@ void stream_agent_stop(StreamAgent *agent)
 static void red_upgrade_item_free(RedUpgradeItem *item)
 {
     g_return_if_fail(item != NULL);
-    g_return_if_fail(item->base.refcount != 0);
+    g_return_if_fail(item->base.refcount == 0);
 
     drawable_unref(item->drawable);
     free(item->rects);
-- 
2.7.4



More information about the Spice-devel mailing list