[Spice-devel] [PATCH 00/23] Using more reference counting on RedPipeItem

Frediano Ziglio fziglio at redhat.com
Mon May 16 13:31:10 UTC 2016


This is the continuation of Christophe patches using reference
counting for RedPipeItem.
Extend it's usage.
This for instance lead to the removal of release_item callback.
Some patches could probably be merged but it's easier to review them.
I did some tests even adding some debugging to see how many items
are allocated and works perfectly.

Frediano Ziglio (23):
  remove unused refs field
  remove useless assignment
  simplify RED_PIPE_ITEM_TYPE_DRAW item release
  call red_pipe_item_unref instead of free
  simplify release of CREATE_SURFACE and DESTROY_SURFACE pipe items
  simplify release of STREAM_CREATE and STREAM_DESTROY pipe items
  handle STREAM_CREATE and STREAM_DESTROY pipe items more coherently
  simplify release_item_after_push
  simplify dcc_release_item
  simplify smartcard_channel_release_pipe_item
  simplify spicevmc_red_channel_release_pipe_item
  remove unused parameter from put_cursor_pipe_item
  reuse RedPipeItem facilities for RedCursorPipeItem
  simplify pipe items release in CursorChannel
  inline dcc_release_item
  use a default release_item implementation in RedChannel
  simplify main_channel_release_pipe_item
  inline main_channel_release_pipe_item
  remove release_item callback
  inline red_channel_client_release_item
  make red_channel_client_clear_sent_item static
  reuse red_channel_client_release_sent_item function
  use reference counting for RedPipeItem

 server/cursor-channel.c  | 72 ++++---------------------------------
 server/dcc-send.c        | 10 +++---
 server/dcc.c             | 92 ++----------------------------------------------
 server/dcc.h             |  6 +---
 server/display-channel.c |  9 -----
 server/display-channel.h |  2 +-
 server/inputs-channel.c  |  7 ----
 server/main-channel.c    | 45 +++++++++--------------
 server/red-channel.c     | 36 +++++--------------
 server/red-channel.h     |  3 --
 server/smartcard.c       | 12 -------
 server/spicevmc.c        | 14 +-------
 server/stream.c          | 37 ++++++++++++++++---
 server/stream.h          |  7 ++--
 14 files changed, 81 insertions(+), 271 deletions(-)

-- 
2.7.4



More information about the Spice-devel mailing list