[Spice-devel] [PATCH 03/15] dc: the worker_ring_item condition make this case terminate loop

Frediano Ziglio fziglio at redhat.com
Mon May 16 16:40:28 UTC 2016


dpi_ring_item is changed but ignored

Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
 server/display-channel.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/server/display-channel.c b/server/display-channel.c
index f19d3db..fc232fb 100644
--- a/server/display-channel.c
+++ b/server/display-channel.c
@@ -514,7 +514,7 @@ static int current_add_equal(DisplayChannel *display, DrawItem *item, TreeItem *
                 dpi = SPICE_CONTAINEROF(dpi_ring_item, RedDrawablePipeItem, base);
                 for (;;) {
                     if (!worker_ring_item) {
-                        break;
+                        goto out_loop;
                     }
                     if (dpi && dcc == dpi->dcc) {
                         break;
@@ -534,6 +534,7 @@ static int current_add_equal(DisplayChannel *display, DrawItem *item, TreeItem *
                                                  worker_ring_item);
                 }
             }
+out_loop:
             /* not sending other_drawable where possible */
             drawable_remove_from_pipes(other_drawable);
 
-- 
2.7.4



More information about the Spice-devel mailing list