[Spice-devel] [PATCH 02/23] remove useless assignment

Jonathon Jongsma jjongsma at redhat.com
Tue May 17 19:44:33 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>

On Mon, 2016-05-16 at 14:31 +0100, Frediano Ziglio wrote:
> type was already initialized calling red_pipe_item_init
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/smartcard.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/server/smartcard.c b/server/smartcard.c
> index e483eec..b2fb766 100644
> --- a/server/smartcard.c
> +++ b/server/smartcard.c
> @@ -541,7 +541,6 @@ static void smartcard_push_error(RedChannelClient *rcc,
> uint32_t reader_id, VSCE
>  
>      red_pipe_item_init(&error_item->base, RED_PIPE_ITEM_TYPE_ERROR);
>  
> -    error_item->base.type = RED_PIPE_ITEM_TYPE_ERROR;
>      error_item->vheader.reader_id = reader_id;
>      error_item->vheader.type = VSC_Error;
>      error_item->vheader.length = sizeof(error_item->error);


More information about the Spice-devel mailing list