[Spice-devel] [PATCH 04/23] call red_pipe_item_unref instead of free

Jonathon Jongsma jjongsma at redhat.com
Tue May 17 19:46:35 UTC 2016


Acked-by: Jonathon Jongsma <jjongsma at redhat.com>

On Mon, 2016-05-16 at 14:31 +0100, Frediano Ziglio wrote:
> This is the standard way to release a RedPipeItem
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/dcc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/dcc.c b/server/dcc.c
> index 0953efd..6f08cd9 100644
> --- a/server/dcc.c
> +++ b/server/dcc.c
> @@ -1676,7 +1676,7 @@ static void
> release_item_before_push(DisplayChannelClient *dcc, RedPipeItem *ite
>      case RED_PIPE_ITEM_TYPE_STREAM_ACTIVATE_REPORT:
>      case RED_PIPE_ITEM_TYPE_GL_SCANOUT:
>      case RED_PIPE_ITEM_TYPE_GL_DRAW:
> -        free(item);
> +        red_pipe_item_unref(item);
>          break;
>      default:
>          spice_critical("invalid item type");


More information about the Spice-devel mailing list