[Spice-devel] [PATCH] glz: simplification of do_match and PIXEL_ID

[Frediano Ziglio]

> 
> On 05/19/2016 09:03 AM, Fabiano Fidêncio wrote:
> > On Wed, May 18, 2016 at 8:20 PM, Uri Lublin <uril at redhat.com> wrote:
> >> Following commit e8017dd366afabbd099a13d7d455a37fd50be124 here
> >> are some more ifdef simplification.
> >>
> >> For PIXEL_ID and PIXEL_DIST macros,
> >> the ifndef LZ_PLT defines are special cases of the LZ_PLT
> >> (#else) defines, when pix_per_byte is 1
> >>
> >> Now do_match can accept pix_per_byte param for all different
> >> definitions (implementations).
> >>
> >> Signed-off-by: Uri Lublin <uril at redhat.com>
> >> ---
> >>  server/glz-encode.tmpl.c | 14 +++-----------
> >>  1 file changed, 3 insertions(+), 11 deletions(-)
> >
> > Patch looks good, but II didn't try to build the patch.
> > I'm assuming you did, you have my ACK.
> >
> > Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
> >
> 
> I did. Thanks.
> 

Patch looks good. The compiler should be easily able to remove the
constant parameter for no palette cases.
Could be however that the "pix_per_byte" could be confusing.
May be pix_per_element (or pix_per_elem) could help or a comment.
The confusing stuff is that PIXEL for PLT are not pixel but bytes.

Frediano