[Spice-devel] [PATCH 00/11] RedChannel refcounting and type safety

Frediano Ziglio fziglio at redhat.com
Fri May 20 13:01:38 UTC 2016


This patchset collect 2 different changes:
- work on RedChannel for reference counting changes
  and cleanup;
- different type safety improvements to avoid structure
  layout assumption and make easier to move/remove fields
  on different structures.

Frediano Ziglio (11):
  Remove RedChannel::hold_item callback
  Handle reference for RedPipeItem in RedChannel
  Call dcc_send_item directly
  Use a marker instead of checking a RedPipeItem presence
  make red_pipe_item_init_full more typesafe
  make red_pipe_item_ref more typesafe
  make red_pipe_item_unref more typesafe
  rename RedVDIReadBug::parent to base
  reduce casts to RedPipeItem and RingItem
  Make sure link in RedPipeItem can be not the first field
  Get code more typesafe

 server/cache-item.tmpl.c |  1 +
 server/char-device.c     |  2 +-
 server/cursor-channel.c  | 23 ++++++++---------------
 server/dcc-encoders.c    |  2 +-
 server/dcc-send.c        | 43 ++++++++++++++++++++-----------------------
 server/dcc.c             | 32 +++++++++++++++++++-------------
 server/dcc.h             |  2 +-
 server/dispatcher.c      |  3 +--
 server/display-channel.c | 41 +++++++++++++++--------------------------
 server/image-cache.c     |  7 +++++--
 server/inputs-channel.c  |  5 -----
 server/main-channel.c    | 23 ++++++++---------------
 server/pixmap-cache.c    |  3 ++-
 server/red-channel.c     | 45 ++++++++++++++++++++++++++++++++++++---------
 server/red-channel.h     |  3 +--
 server/red-pipe-item.c   | 12 ++++--------
 server/red-pipe-item.h   | 16 +++++++++++-----
 server/red-replay-qxl.c  |  2 +-
 server/reds.c            | 37 +++++++++++++++++++------------------
 server/smartcard.c       | 20 +++++++-------------
 server/spicevmc.c        | 15 +++------------
 server/stream.c          | 17 ++++++++++-------
 server/tree.c            | 12 +++++++-----
 server/tree.h            |  8 ++++----
 24 files changed, 185 insertions(+), 189 deletions(-)

-- 
2.7.4



More information about the Spice-devel mailing list