[Spice-devel] [PATCHv2 2/3] egl: don't terminate display

[Victor Toso]

On Mon, May 23, 2016 at 05:28:21PM +0200, Pavel Grunt wrote:
> Thanks for adding all the comments,
> 
> ack from me

Acked-by: Victor Toso <victortoso at redhat.com>
and series.

Thanks!

> 
> Pavel
> 
> On Mon, 2016-05-23 at 13:01 +0200, Marc-André Lureau wrote:
> > This is global to the display connection: all egl resources will be
> > released, including those from other widgets or from the application.
> > 
> > Fix spice/virgl display being rendered black after another widget
> > display is destroyed.
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> > ---
> >  src/spice-widget-egl.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/spice-widget-egl.c b/src/spice-widget-egl.c
> > index a3db856..0054bc9 100644
> > --- a/src/spice-widget-egl.c
> > +++ b/src/spice-widget-egl.c
> > @@ -390,7 +390,9 @@ void spice_egl_unrealize_display(SpiceDisplay *display)
> >  
> >          eglMakeCurrent(d->egl.display, EGL_NO_SURFACE, EGL_NO_SURFACE,
> >                         EGL_NO_CONTEXT);
> > -        eglTerminate(d->egl.display);
> > +
> > +        /* do not call eglterminate() since egl may be used by
> > +         * somebody else code */
> >      }
> >  }
> >