[Spice-devel] [PATCH 7/7] Limit direct access to DisplayChannelClient

Jonathon Jongsma jjongsma at redhat.com
Mon May 23 20:17:40 UTC 2016


On Sun, 2016-05-22 at 04:19 -0400, Frediano Ziglio wrote:

> >  /* FIXME: move back to display-channel.h (once structs are private) */
> >  typedef struct Drawable Drawable;
> > -typedef struct DisplayChannelClient DisplayChannelClient;
> >  
> 
> We definitively should consider using struct Xxxx instead of moving
> these typedef everytime in order to compile...

Or create a spice-types.h header that contains forward declarations for all
structs and include that in every other file. The includes really are quite a
tangled mess and it's not an easy problem to unravel. I spent some time trying,
but it's very difficult to do in a gradual way. I've resisted doing something
like this in the past, but I'm starting to warm up to it...

Jonathon


More information about the Spice-devel mailing list