[Spice-devel] [PATCHv2 2/4] gtk: rename spicex_* functions

Marc-André Lureau marcandre.lureau at gmail.com
Wed May 25 10:20:14 UTC 2016


spice-gtk used to have x11/shm backend, now it's only cairo

Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
---
 src/spice-widget-cairo.c |  8 ++++----
 src/spice-widget-priv.h  |  8 ++++----
 src/spice-widget.c       | 27 +++++++++++++--------------
 3 files changed, 21 insertions(+), 22 deletions(-)

diff --git a/src/spice-widget-cairo.c b/src/spice-widget-cairo.c
index bd7ce6a..0e84649 100644
--- a/src/spice-widget-cairo.c
+++ b/src/spice-widget-cairo.c
@@ -23,7 +23,7 @@
 
 
 G_GNUC_INTERNAL
-int spicex_image_create(SpiceDisplay *display)
+int spice_cairo_image_create(SpiceDisplay *display)
 {
     SpiceDisplayPrivate *d = display->priv;
 
@@ -51,7 +51,7 @@ int spicex_image_create(SpiceDisplay *display)
 }
 
 G_GNUC_INTERNAL
-void spicex_image_destroy(SpiceDisplay *display)
+void spice_cairo_image_destroy(SpiceDisplay *display)
 {
     SpiceDisplayPrivate *d = display->priv;
 
@@ -62,7 +62,7 @@ void spicex_image_destroy(SpiceDisplay *display)
 }
 
 G_GNUC_INTERNAL
-void spicex_draw_event(SpiceDisplay *display, cairo_t *cr)
+void spice_cairo_draw_event(SpiceDisplay *display, cairo_t *cr)
 {
     SpiceDisplayPrivate *d = display->priv;
     cairo_rectangle_int_t rect;
@@ -130,7 +130,7 @@ void spicex_draw_event(SpiceDisplay *display, cairo_t *cr)
 }
 
 G_GNUC_INTERNAL
-gboolean spicex_is_scaled(SpiceDisplay *display)
+gboolean spice_cairo_is_scaled(SpiceDisplay *display)
 {
     SpiceDisplayPrivate *d = display->priv;
     return d->allow_scaling;
diff --git a/src/spice-widget-priv.h b/src/spice-widget-priv.h
index 266cc87..e36baf3 100644
--- a/src/spice-widget-priv.h
+++ b/src/spice-widget-priv.h
@@ -147,10 +147,10 @@ struct _SpiceDisplayPrivate {
 #endif
 };
 
-int      spicex_image_create                 (SpiceDisplay *display);
-void     spicex_image_destroy                (SpiceDisplay *display);
-void     spicex_draw_event                   (SpiceDisplay *display, cairo_t *cr);
-gboolean spicex_is_scaled                    (SpiceDisplay *display);
+int      spice_cairo_image_create                 (SpiceDisplay *display);
+void     spice_cairo_image_destroy                (SpiceDisplay *display);
+void     spice_cairo_draw_event                   (SpiceDisplay *display, cairo_t *cr);
+gboolean spice_cairo_is_scaled                    (SpiceDisplay *display);
 void     spice_display_get_scaling           (SpiceDisplay *display, double *s, int *x, int *y, int *w, int *h);
 gboolean spice_egl_init                      (SpiceDisplay *display, GError **err);
 gboolean spice_egl_realize_display           (SpiceDisplay *display, GdkWindow *win,
diff --git a/src/spice-widget.c b/src/spice-widget.c
index 2272a26..a37faad 100644
--- a/src/spice-widget.c
+++ b/src/spice-widget.c
@@ -417,7 +417,7 @@ static void spice_display_dispose(GObject *obj)
 
     SPICE_DEBUG("spice display dispose");
 
-    spicex_image_destroy(display);
+    spice_cairo_image_destroy(display);
     g_clear_object(&d->session);
     d->gtk_session = NULL;
 
@@ -1113,7 +1113,7 @@ static void recalc_geometry(GtkWidget *widget)
     SpiceDisplayPrivate *d = display->priv;
     gdouble zoom = 1.0;
 
-    if (spicex_is_scaled(display))
+    if (spice_cairo_is_scaled(display))
         zoom = (gdouble)d->zoom_level / 100;
 
     SPICE_DEBUG("recalc geom monitor: %d:%d, guest +%d+%d:%dx%d, window %dx%d, zoom %g",
@@ -1229,7 +1229,7 @@ static gboolean draw_event(GtkWidget *widget, cairo_t *cr, gpointer data)
         return false;
     g_return_val_if_fail(d->canvas.surface != NULL, false);
 
-    spicex_draw_event(display, cr);
+    spice_cairo_draw_event(display, cr);
     update_mouse_pointer(display);
 
     return true;
@@ -1743,10 +1743,9 @@ static int button_mask_gdk_to_spice(int gdk)
     return spice;
 }
 
-G_GNUC_INTERNAL
-void spicex_transform_input (SpiceDisplay *display,
-                             double window_x, double window_y,
-                             int *input_x, int *input_y)
+static void transform_input(SpiceDisplay *display,
+                            double window_x, double window_y,
+                            int *input_x, int *input_y)
 {
     SpiceDisplayPrivate *d = display->priv;
     int display_x, display_y, display_w, display_h;
@@ -1799,7 +1798,7 @@ static gboolean motion_event(GtkWidget *widget, GdkEventMotion *motion)
         try_keyboard_grab(display);
     }
 
-    spicex_transform_input (display, motion->x, motion->y, &x, &y);
+    transform_input(display, motion->x, motion->y, &x, &y);
 
     switch (d->mouse_mode) {
     case SPICE_MOUSE_MODE_CLIENT:
@@ -1872,7 +1871,7 @@ static gboolean button_event(GtkWidget *widget, GdkEventButton *button)
     if (d->disable_inputs)
         return true;
 
-    spicex_transform_input (display, button->x, button->y, &x, &y);
+    transform_input(display, button->x, button->y, &x, &y);
     if ((x < 0 || x >= d->area.width ||
          y < 0 || y >= d->area.height) &&
         d->mouse_mode == SPICE_MOUSE_MODE_CLIENT) {
@@ -1956,7 +1955,7 @@ static void update_image(SpiceDisplay *display)
 {
     SpiceDisplayPrivate *d = display->priv;
 
-    spicex_image_create(display);
+    spice_cairo_image_create(display);
     if (d->canvas.convert)
         do_color_convert(display, &d->area);
 }
@@ -1977,7 +1976,7 @@ static void realize(GtkWidget *widget)
 
 static void unrealize(GtkWidget *widget)
 {
-    spicex_image_destroy(SPICE_DISPLAY(widget));
+    spice_cairo_image_destroy(SPICE_DISPLAY(widget));
 #ifndef G_OS_WIN32
     spice_egl_unrealize_display(SPICE_DISPLAY(widget));
 #endif
@@ -2323,7 +2322,7 @@ static void update_area(SpiceDisplay *display,
     if (!d->egl.enabled)
 #endif
     {
-        spicex_image_destroy(display);
+        spice_cairo_image_destroy(display);
         if (gtk_widget_get_realized(GTK_WIDGET(display)))
             update_image(display);
     }
@@ -2354,7 +2353,7 @@ static void primary_destroy(SpiceChannel *channel, gpointer data)
     SpiceDisplay *display = SPICE_DISPLAY(data);
     SpiceDisplayPrivate *d = display->priv;
 
-    spicex_image_destroy(display);
+    spice_cairo_image_destroy(display);
     d->canvas.width  = 0;
     d->canvas.height = 0;
     d->canvas.stride = 0;
@@ -2512,7 +2511,7 @@ void spice_display_get_scaling(SpiceDisplay *display,
         wh = fbh;
     }
 
-    if (!spicex_is_scaled(display)) {
+    if (!spice_cairo_is_scaled(display)) {
         s = 1.0;
         x = 0;
         y = 0;
-- 
2.7.4



More information about the Spice-devel mailing list