[Spice-devel] Different styles

Jonathon Jongsma jjongsma at redhat.com
Wed May 25 14:48:48 UTC 2016


On Wed, 2016-05-25 at 16:12 +0200, Victor Toso wrote:
> Hi!
> 
> On Wed, May 25, 2016 at 08:31:45AM -0400, Frediano Ziglio wrote:

> > I personally find that vertical indentation tend to cause long lines and
> > it's hard to maintain when new declarations are added (like requiring
> > new indentation)
> 
> I personally like it with struct members or function arguments. As you
> put some samples above, why not:
> 
> struct TosoClass {
>     gchar       *name;
>     guint8       age;
> 
>     BigStructureHere    *ptr;
>     SmallerSt            abc;
> };
> 
> static void multiple_arg_fn(const gchar         *name,
>                             guint8               age,
>                             BigStructureHere   **pp,
>                             SmallerSt           *edf)
> {
> 
> :-)

Purely a personal preference of course, but I really dislike that. It means that
if I add a really long struct member or function argument, I have to choose
between re-indenting everything (which makes e.g. git blame less useful), or
having mis-aligned struct members.

Jonathon


More information about the Spice-devel mailing list