[Spice-devel] [PATCH spice-gtk 2/2] file-transfer-task: Hide internals of SpiceFileTransferTask

[Marc-André Lureau]

Hi

On Wed, May 25, 2016 at 7:30 AM, Pavel Grunt <pgrunt at redhat.com> wrote:
> ---
>  doc/reference/spice-gtk-sections.txt |  4 ++--
>  src/channel-main.c                   | 24 ++++++++++++++++++++++++
>  src/spice-file-transfer-task.h       | 23 -----------------------
>  3 files changed, 26 insertions(+), 25 deletions(-)
>
> diff --git a/doc/reference/spice-gtk-sections.txt b/doc/reference/spice-gtk-sections.txt
> index b67dd35..9a86553 100644
> --- a/doc/reference/spice-gtk-sections.txt
> +++ b/doc/reference/spice-gtk-sections.txt
> @@ -494,8 +494,6 @@ SpiceWebdavChannelPrivate
>  <SECTION>
>  <FILE>file-transfer-task</FILE>
>  <TITLE>SpiceFileTransferTask</TITLE>
> -SpiceFileTransferTask
> -SpiceFileTransferTaskClass
>  <SUBSECTION>
>  spice_file_transfer_task_get_progress
>  spice_file_transfer_task_get_filename
> @@ -509,5 +507,7 @@ SPICE_FILE_TRANSFER_TASK_CLASS
>  SPICE_IS_FILE_TRANSFER_TASK_CLASS
>  SPICE_FILE_TRANSFER_TASK_GET_CLASS
>  <SUBSECTION Private>
> +SpiceFileTransferTask
> +SpiceFileTransferTaskClass
>  SpiceFileTransferTaskPrivate
>  </SECTION>
> diff --git a/src/channel-main.c b/src/channel-main.c
> index dec5d73..b91daa5 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -71,6 +71,30 @@ typedef struct spice_migrate spice_migrate;
>   *
>   * Since: 0.31
>   */
> +
> +/**
> + * SpiceFileTransferTask:
> + *
> + * The #SpiceFileTransferTask struct is opaque and should not be accessed directly.
> + */
> +struct _SpiceFileTransferTask
> +{
> +    GObject parent;
> +
> +    SpiceFileTransferTaskPrivate *priv;
> +};
> +
> +/**
> + * SpiceFileTransferTaskClass:
> + * @parent_class: Parent class.
> + *
> + * Class structure for #SpiceFileTransferTask.
> + */
> +struct _SpiceFileTransferTaskClass
> +{
> +    GObjectClass parent_class;
> +};
> +
>  G_DEFINE_TYPE(SpiceFileTransferTask, spice_file_transfer_task, G_TYPE_OBJECT)
>
>  #define FILE_TRANSFER_TASK_PRIVATE(o) \
> diff --git a/src/spice-file-transfer-task.h b/src/spice-file-transfer-task.h
> index fba132e..389668e 100644
> --- a/src/spice-file-transfer-task.h
> +++ b/src/spice-file-transfer-task.h
> @@ -40,29 +40,6 @@ typedef struct _SpiceFileTransferTask SpiceFileTransferTask;
>  typedef struct _SpiceFileTransferTaskClass SpiceFileTransferTaskClass;
>  typedef struct _SpiceFileTransferTaskPrivate SpiceFileTransferTaskPrivate;
>
> -/**
> - * SpiceFileTransferTask:
> - *
> - * The #SpiceFileTransferTask struct is opaque and should not be accessed directly.
> - */
> -struct _SpiceFileTransferTask
> -{
> -    GObject parent;
> -
> -    SpiceFileTransferTaskPrivate *priv;
> -};
> -
> -/**
> - * SpiceFileTransferTaskClass:
> - * @parent_class: Parent class.
> - *
> - * Class structure for #SpiceFileTransferTask.
> - */
> -struct _SpiceFileTransferTaskClass
> -{
> -    GObjectClass parent_class;
> -};
> -

Notice this is a "small" API break. We have done only spice-client-gtk
API/ABI break in the coming 0.32 series.

>  GType spice_file_transfer_task_get_type(void) G_GNUC_CONST;
>
>  char* spice_file_transfer_task_get_filename(SpiceFileTransferTask *self);
> --
> 2.8.3
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel



-- 
Marc-André Lureau