[Spice-devel] [PATCH spice-gtk v4 0/8] Allow ipv6 proxy url
Pavel Grunt
pgrunt at redhat.com
Mon May 30 15:46:42 UTC 2016
Hi,
these patches add ipv6 support to SpiceUri, so it can be used in SPICE_PROXY.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1335239
v4 contains changes suggested by Christophe, Victor, Frediano:
- Added check for scheme
- Tests check for error messages
- Port 0 is considered invalid
- Fixed memory leaks
v3 per Frediano's review:
- Added test for port out of range (0, 65535)
- reset all values of SpiceUri before parsing
v2 contains changes suggested by Frediano and Victor:
- more tests (missing port, missing ending bracket)
- tests are defined in array, so it is easier to add new test cases
- follow ipv6 address format http://user:password@[ipv6]:port
Thanks,
Pavel Grunt (8):
tests: Add test for SpiceUri
spice-uri: Mark parameter as unused
spice-uri: Add missing include
spice-uri: Reset SpiceUri before parsing
spice-uri: Do not allow empty port string
spice-uri: Check if port is in allowed range
spice-uri: Validate uri scheme
spice-uri: Add ipv6 support
src/spice-uri.c | 79 ++++++++++++++++++++-------
tests/Makefile.am | 2 +
tests/test-spice-uri.c | 142 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 203 insertions(+), 20 deletions(-)
create mode 100644 tests/test-spice-uri.c
--
2.8.3
More information about the Spice-devel
mailing list