[Spice-devel] [spice v15 02/21] streaming: Remove the width/height encode_frame() parameters

[Christophe Fergeau]

Hi,

On Mon, May 30, 2016 at 07:12:48PM +0200, Francois Gouget wrote:
> On Fri, 27 May 2016, Christophe Fergeau wrote:
> > I'm afraid this bit is not going to work as expected with older clients
> > (ones not supporting SPICE_DISPLAY_CAP_SIZED_STREAM).
> 
> This chunk does not change whether we send a SpiceMsgDisplayStreamData 
> or a SpiceMsgDisplayStreamDataSized message. Furthermore, the width / 
> height we computed here are only used in the DataSized case and in 
> that case we still send the frame's width / height of course:

Maybe I should have commented on 1/21 rather than this patch as this
really is 1/21 which does not seem correct in the !SIZED_STREAM case
rather than this one. I'll comment there.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160531/85dcd1e3/attachment.sig>