[Spice-devel] [PATCH spice-server v2 06/12] fixup! Re-arrange channel client creation to avoid exposing client lock

Pavel Grunt pgrunt at redhat.com
Tue Nov 1 14:08:51 UTC 2016


Ack

On Tue, 2016-11-01 at 11:08 +0000, Frediano Ziglio wrote:
> Fix style
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  server/dummy-channel-client.c | 3 ++-
>  server/red-channel-client.c   | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/server/dummy-channel-client.c b/server/dummy-channel-
> client.c
> index e43546c..a39941c 100644
> --- a/server/dummy-channel-client.c
> +++ b/server/dummy-channel-client.c
> @@ -44,8 +44,9 @@ static gboolean
> dummy_channel_client_initable_init(GInitable *initable,
>      RedClient *client = red_channel_client_get_client(rcc);
>      RedChannel *channel = red_channel_client_get_channel(rcc);
>  
> -    if (!red_client_add_channel(client, rcc, &local_error))
> +    if (!red_client_add_channel(client, rcc, &local_error)) {
>          goto cleanup;
> +    }
>  
>      red_channel_add_client(channel, rcc);
>  
> diff --git a/server/red-channel-client.c b/server/red-channel-
> client.c
> index 8213f13..5a462dc 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channel-client.c
> @@ -869,8 +869,9 @@ static gboolean
> red_channel_client_initable_init(GInitable *initable,
>      GError *local_error = NULL;
>      SpiceCoreInterfaceInternal *core;
>      RedChannelClient *self = RED_CHANNEL_CLIENT(initable);
> -    if (!red_client_add_channel(self->priv->client, self,
> &local_error))
> +    if (!red_client_add_channel(self->priv->client, self,
> &local_error)) {
>          goto cleanup;
> +    }
>  
>      if (!red_channel_config_socket(self->priv->channel, self)) {
>          g_set_error_literal(&local_error,


More information about the Spice-devel mailing list