[Spice-devel] [PATCH spice-server v2 04/12] red-channel-client: Remove only written field

Pavel Grunt pgrunt at redhat.com
Tue Nov 1 14:17:51 UTC 2016


On Tue, 2016-11-01 at 11:07 +0000, Frediano Ziglio wrote:
> id field of RedChannelClient is not used and marked as debugging.
> Also it's value is quite confusing.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
Acked-by: Pavel Grunt <pgrunt at redhat.com>
> ---
>  server/red-channel-client-private.h | 1 -
>  server/red-channel-client.c         | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/server/red-channel-client-private.h b/server/red-
> channel-client-private.h
> index e77cdf9..38759ff 100644
> --- a/server/red-channel-client-private.h
> +++ b/server/red-channel-client-private.h
> @@ -87,7 +87,6 @@ struct RedChannelClientPrivate
>      } send_data;
>  
>      int during_send;
> -    int id; // debugging purposes
>      GQueue pipe;
>  
>      RedChannelCapabilities remote_caps;
> diff --git a/server/red-channel-client.c b/server/red-channel-
> client.c
> index 42f1d2c..a28f5e6 100644
> --- a/server/red-channel-client.c
> +++ b/server/red-channel-client.c
> @@ -924,7 +924,6 @@ static gboolean
> red_channel_client_initable_init(GInitable *initable,
>          self->priv->latency_monitor.roundtrip = -1;
>      }
>  
> -    self->priv->id = red_channel_get_n_clients(self->priv-
> >channel);
>      red_channel_add_client(self->priv->channel, self);
>      red_client_add_channel(self->priv->client, self);
>  


More information about the Spice-devel mailing list