[Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

[Christophe Fergeau]

On Mon, Nov 07, 2016 at 04:08:48AM -0500, Frediano Ziglio wrote:
> > @@ -124,9 +157,18 @@ void qxl_display_read_client_monitors_config(struct
> > qxl_device *qdev)
> >  {
> >  
> >  	struct drm_device *dev = qdev->ddev;
> > -	while (qxl_display_copy_rom_client_monitors_config(qdev)) {
> > +	int status;
> > +
> > +	status = qxl_display_copy_rom_client_monitors_config(qdev);
> > +	while (status == MONITORS_CONFIG_BAD_CRC) {
> >  		qxl_io_log(qdev, "failed crc check for client_monitors_config,"
> >  				 " retrying\n");
> > +		status = qxl_display_copy_rom_client_monitors_config(qdev);
> > +	}
> > +	if (status == MONITORS_CONFIG_UNCHANGED) {
> > +		qxl_io_log(qdev, "config unchanged\n");
> > +		DRM_DEBUG("ignoring unchanged client monitors config");
> 
> Why log and debug? Looks like a missing debug cleanup.

qxl_io_log is going to be output host-side, DRM_DEBUG is guest-side,
having both was intentional.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161107/8255cfc1/attachment.sig>