[Spice-devel] [PATCH spice-server v2 3/6] Simplify gstreamer 0.10 compatibility

[Frediano Ziglio]

> On Fri, Oct 21, 2016 at 01:40:37PM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/gstreamer-encoder.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> > 
> > diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> > index 53dfb98..d8437e4 100644
> > --- a/server/gstreamer-encoder.c
> > +++ b/server/gstreamer-encoder.c
> > @@ -967,11 +967,7 @@ static gboolean create_pipeline(SpiceGstEncoder
> > *encoder)
> >      encoder->gstenc = gst_bin_get_by_name(GST_BIN(encoder->pipeline),
> >      "encoder");
> >      encoder->appsink =
> >      GST_APP_SINK(gst_bin_get_by_name(GST_BIN(encoder->pipeline),
> >      "sink"));
> >  
> > -#ifdef HAVE_GSTREAMER_0_10
> > -    GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample, NULL,
> > {NULL}};
> > -#else
> > -    GstAppSinkCallbacks appsink_cbs = {NULL, NULL, &new_sample, {NULL}};
> > -#endif
> > +    GstAppSinkCallbacks appsink_cbs = { NULL, NULL, new_sample };
> 
> This actually breaks the build with -Werror=missing-field-initializers
> which we have by default in our flags.
> 
> Christophe
> 

Apparently on my build the same script that is supposed to turn this
flag on also turn it off later!
I'll write an update for both.

Frediano