[Spice-devel] [PATCH spice-server v2 1/6] gstreamer: Do not warn for tested formats

[Frediano Ziglio]

> 
> 
> From the commit log, I have no idea why/how they were tested now. If you
> tested them locally, just mention this in the log.
> 

This was tested with the utility at 4/6 and the script at 6/6.

Maybe:

"These formats were tested manually using a small test utility."

> Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Christophe
> 

Frediano

> On Fri, Oct 21, 2016 at 01:40:35PM +0100, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> > ---
> >  server/gstreamer-encoder.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c
> > index d575c67..53dfb98 100644
> > --- a/server/gstreamer-encoder.c
> > +++ b/server/gstreamer-encoder.c
> > @@ -757,7 +757,7 @@ static const SpiceFormatForGStreamer format_map[] =  {
> >      {SPICE_BITMAP_FMT_INVALID, "", 0, 0, 0, 0, 0, 0},
> >      {SPICE_BITMAP_FMT_RGBA, "BGRA", 32, 24, 4321, 0xff000000, 0xff0000,
> >      0xff00},
> >      {SPICE_BITMAP_FMT_16BIT, "RGB15", 16, 15, 4321, 0x001f, 0x03E0,
> >      0x7C00},
> > -    /* TODO: Test the other formats */
> > +    /* TODO: Test the other formats under GStreamer 0.10*/
> >      {SPICE_BITMAP_FMT_32BIT, "BGRx", 32, 24, 4321, 0xff000000, 0xff0000,
> >      0xff00},
> >      {SPICE_BITMAP_FMT_24BIT, "BGR", 24, 24, 4321, 0xff0000, 0xff00, 0xff},
> >  };
> > @@ -769,9 +769,11 @@ static const SpiceFormatForGStreamer
> > *map_format(SpiceBitmapFmt format)
> >      int i;
> >      for (i = 0; i < G_N_ELEMENTS(format_map); i++) {
> >          if (format_map[i].spice_format == format) {
> > +#ifdef HAVE_GSTREAMER_0_10
> >              if (i > 2) {
> >                  spice_warning("The %d format has not been tested yet",
> >                  format);
> >              }
> > +#endif
> >              return &format_map[i];
> >          }
> >      }